Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Fix mdformat version to support python3.6 #2014

Merged
merged 4 commits into from
Jun 9, 2022
Merged

[Docs] Fix mdformat version to support python3.6 #2014

merged 4 commits into from
Jun 9, 2022

Conversation

zhouzaida
Copy link
Collaborator

@zhouzaida zhouzaida commented May 27, 2022 •
edited
Loading

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

  • Fix mdformat version to support python3.6 and refine documentation.
  • Remove ruby from CI

Modification

  • TERMINOLOGY.md
  • docs
  • .pre-commit-config.yaml

BC-breaking (Optional)

No

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zhouzaida zhouzaida requested a review from HAOCHENYE June 7, 2022 02:25
@zhouzaida zhouzaida linked an issue Jun 7, 2022 that may be closed by this pull request
ERROR: Package 'mdformat' requires a different Python: 3.6.12 not in '<4.0,>=3.7' #2028
Closed
HAOCHENYE
HAOCHENYE reviewed Jun 9, 2022
View reviewed changes
Copy link
Collaborator

@HAOCHENYE HAOCHENYE left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/open-mmlab/mmcv/blame/f13a7ef56298b22a12d514cf7ebc11bd34e3433e/docs/zh_cn/deployment/onnxruntime_op.md#L129
and https://github.com/open-mmlab/mmcv/blame/f13a7ef56298b22a12d514cf7ebc11bd34e3433e/docs/zh_cn/deployment/onnxruntime_op.md#L103
is invalid

@zhouzaida
Copy link
Collaborator Author

https://github.com/open-mmlab/mmcv/blame/f13a7ef56298b22a12d514cf7ebc11bd34e3433e/docs/zh_cn/deployment/onnxruntime_op.md#L129 and https://github.com/open-mmlab/mmcv/blame/f13a7ef56298b22a12d514cf7ebc11bd34e3433e/docs/zh_cn/deployment/onnxruntime_op.md#L103 is invalid

fixed

@zhouzaida zhouzaida changed the title [Docs] Refine documentation [Docs] Fix mdformat version to support python3.6 and refine documentation Jun 9, 2022
@zhouzaida zhouzaida changed the title [Docs] Fix mdformat version to support python3.6 and refine documentation [Docs] Fix mdformat version to support python3.6 Jun 9, 2022
@zhouzaida zhouzaida merged commit 11d8554 into open-mmlab:master Jun 9, 2022
@zhouzaida zhouzaida deleted the refine-docs branch June 9, 2022 09:47
This was referenced Jun 15, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HAOCHENYE HAOCHENYE HAOCHENYE approved these changes

Assignees

@teamwong111 teamwong111

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR: Package 'mdformat' requires a different Python: 3.6.12 not in '<4.0,>=3.7'
3 participants
@zhouzaida @HAOCHENYE @teamwong111